Skip to content

Porting From pi-mono: A Practical Merge Guide

This guide is a repeatable checklist for porting changes from pi-mono into this repo. Use it for any merge: single file, feature branch, or full release sync.

Last Sync Point

Commit: b21b42d032919de2f2e6920a76fa9a37c3920c0aDate: 2026-03-22

Update this section after each sync; do not reuse the previous range.

When starting a new sync, generate patches from this commit forward:

bash
git format-patch b21b42d032919de2f2e6920a76fa9a37c3920c0a..HEAD --stdout > changes.patch

0) Define the scope

  • Identify the upstream reference (commit, tag, or PR).
  • List the packages or folders you plan to touch.
  • Decide which features are in-scope and which are intentionally skipped.

1) Bring code over safely

  • Prefer a clean, focused diff rather than a wholesale copy.
  • Avoid copying built artifacts or generated files.
  • If upstream added new files, add them explicitly and review contents.

2) Match import extension conventions

Most runtime TypeScript sources omit .js in internal imports, but some test/bench entrypoints keep .js for ESM runtime compatibility. Follow the local package’s existing style; do not blanket-strip extensions.

  • In packages/coding-agent runtime sources, keep internal imports extensionless unless importing non-TS assets.
  • In packages/tui/test and packages/natives/bench, keep .js where surrounding files already use it.
  • Keep real file extensions when required by tooling (e.g., .json, .css, .md text embeds).
  • Example: import { x } from "./foo.js";import { x } from "./foo"; (only when the package convention is extensionless).

3) Replace import scopes

Upstream uses different package scopes. Replace them consistently.

  • Replace old scopes with the local scope used here.
  • Examples (adjust to match the actual packages you are porting):
    • @mariozechner/pi-coding-agent@oh-my-pi/pi-coding-agent
    • @mariozechner/pi-agent-core@oh-my-pi/pi-agent-core
    • @mariozechner/pi-tui@oh-my-pi/pi-tui
    • @mariozechner/pi-ai@oh-my-pi/pi-ai

4) Use Bun APIs where they improve on Node

We run on Bun. Replace Node APIs only when Bun provides a better alternative.

DO replace:

  • Process spawning: child_process.spawn → Bun Shell $ for simple commands, Bun.spawn/Bun.spawnSync for streaming or long-running work
  • File I/O: fs.readFileSyncBun.file().text() / Bun.write()
  • HTTP clients: node-fetch, axios → native fetch
  • Crypto hashing: node:crypto → Web Crypto or Bun.hash
  • SQLite: better-sqlite3bun:sqlite
  • Env loading: dotenv → Bun loads .env automatically

DO NOT replace (these work fine in Bun):

  • os.homedir() — do NOT replace with Bun.env.HOME, Bun.env.HOME, or literal "~"
  • os.tmpdir() — do NOT replace with Bun.env.TMPDIR || "/tmp" or hardcoded paths
  • fs.mkdtempSync() — do NOT replace with manual path construction
  • path.join(), path.resolve(), etc. — these are fine

Import style: Use the node: prefix with namespace imports only (no named imports from node:fs or node:path).

Additional Bun conventions:

  • Prefer Bun Shell $ for short, non-streaming commands; use Bun.spawn only when you need streaming I/O or process control.
  • Use Bun.file()/Bun.write() for files and node:fs/promises for directories.
  • Avoid Bun.file().exists() checks; use isEnoent handling in try/catch.
  • Prefer Bun.sleep(ms) over setTimeout wrappers.

Wrong:

typescript
// BROKEN: env vars may be undefined, "~" is not expanded
const home = Bun.env.HOME || "~";
const tmp = Bun.env.TMPDIR || "/tmp";

Correct:

typescript
import * as os from "node:os";
import * as fs from "node:fs";
import * as path from "node:path";

const configDir = path.join(os.homedir(), ".config", "myapp");
const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), "myapp-"));

5) Prefer Bun embeds (no copying)

Do not copy runtime assets or vendor files at build time.

  • If upstream copies assets into a dist folder, replace with Bun-friendly embeds.
  • Prompts are static .md files; use Bun text imports (with { type: "text" }) and Handlebars instead of inline prompt strings.
  • Use import.meta.dir + Bun.file to load adjacent non-text resources.
  • Keep assets in-repo and let the bundler include them.
  • Eliminate copy scripts unless the user explicitly requests them.
  • If upstream reads a bundled fallback file at runtime, replace filesystem reads with a Bun text embed import.
    • Example (Codex instructions fallback):
      • const FALLBACK_PROMPT_PATH = join(import.meta.dir, "codex-instructions.md"); -> removed
      • import FALLBACK_INSTRUCTIONS from "./codex-instructions.md" with { type: "text" };
      • Use return FALLBACK_INSTRUCTIONS; instead of readFileSync(FALLBACK_PROMPT_PATH, "utf8")

6) Port package.json carefully

Treat package.json as a contract. Merge intentionally.

  • Keep existing name, version, type, exports, and bin unless the port requires changes.
  • Replace npm/node scripts with Bun equivalents (e.g., bun check, bun test).
  • Ensure dependencies use the correct scope.
  • Do not downgrade dependencies to fix type errors; upgrade instead.
  • Validate workspace package links and peerDependencies.

7) Align code style and tooling

  • Keep existing formatting conventions.
  • Do not introduce any unless required.
  • Avoid dynamic imports and inline type imports; use top-level imports only.
  • Never build prompts in code; prompts are static .md files rendered with Handlebars.
  • In coding-agent, never use console.log/console.warn/console.error; use logger from @oh-my-pi/pi-utils.
  • Use Promise.withResolvers() instead of new Promise((resolve, reject) => ...).
  • No private/protected/public keywords on class fields or methods. Use ES # private fields for encapsulation; leave accessible members bare (no keyword). The only exception is constructor parameter properties (constructor(private readonly x: T)), where the keyword is required by TypeScript. When porting upstream code that uses private foo or protected bar, convert to #foo (private) or bare bar (accessible).
  • Prefer existing helpers and utilities over new ad-hoc code.
  • Preserve Bun-first infrastructure changes already made in this repo:
    • Runtime is Bun (no Node entry points).
    • Package manager is Bun (no npm lockfiles).
    • Heavy Node APIs (child_process, readline) are replaced with Bun equivalents.
    • Lightweight Node APIs (os.homedir, os.tmpdir, fs.mkdtempSync, path.*) are kept.
    • CLI shebangs use bun (not node, not tsx).
    • Packages use source files directly (no TypeScript build step).
    • CI workflows run Bun for install/check/test.

8) Remove old compatibility layers

Unless requested, remove upstream compatibility shims.

  • Delete old APIs that were replaced.
  • Update all call sites to the new API directly.
  • Do not keep *_v2 or parallel versions.

9) Update docs and references

  • Replace pi-mono repo links where appropriate.
  • Update examples to use Bun and correct package scopes.
  • Ensure README instructions still match the current repo behavior.

10) Validate the port

Run the standard checks after changes:

  • bun check

If the repo already has failing checks unrelated to your changes, call that out. Tests use Bun's runner (not Vitest), but only run bun test when explicitly requested.

11) Protect improved features (regression trap list)

If you already improved behavior locally, treat those as non‑negotiable. Before porting, write down the improvements and add explicit checks so they don’t get lost in the merge.

  • Freeze the expected behavior: add a short “before/after” note for each improvement (inputs, outputs, defaults, edge cases). This prevents silent rollback.
  • Map old → new APIs: if upstream renamed concepts (hooks → extensions, custom tools → tools, etc.), ensure every old entry point still wires through. One missed flag or export equals lost functionality.
  • Verify exports: check package.json exports, public types, and barrel files. Upstream ports often forget to re-export local additions.
  • Cover non‑happy paths: if you fixed error handling, timeouts, or fallback logic, add a test or at least a manual checklist that exercises those paths.
  • Check defaults and config merge order: improvements often live in defaults. Confirm new defaults didn’t revert (e.g., new config precedence, disabled features, tool lists).
  • Audit env/shell behavior: if you fixed execution or sandboxing, verify the new path still uses your sanitized env and does not reintroduce alias/function overrides.
  • Re-run targeted samples: keep a minimal set of "known good" examples and run them after the port (CLI flags, extension registration, tool execution).

12) Detect and handle reworked code

Before porting a file, check if upstream significantly refactored it:

bash
# Compare the file you're about to port against what you have locally
git diff HEAD upstream/main -- path/to/file.ts

If the diff shows the file was reworked (not just patched):

  • New abstractions, renamed concepts, merged modules, changed data flow

Then you must read the new implementation thoroughly before porting. Blind merging of reworked code loses functionality because:

Note: interactive mode was recently split into controllers/utils/types. When backporting related changes, port updates into the individual files we created and ensure interactive-mode.ts wiring stays in sync.

  1. Defaults change silently - A new variable defaultFoo = [a, b] may replace an old getAllFoo() that returned [a, b, c, d, e].

  2. API options get dropped - When systems merge (e.g., hooks + customToolsextensions), old options may not wire through to the new implementation.

  3. Code paths go stale - A renamed concept (e.g., hookMessagecustom) needs updates in every switch statement, type guard, and handler—not just the definition.

  4. Context/capabilities shrink - Old APIs may have exposed { logger, typebox, pi } that new APIs forgot to include.

Semantic porting process

When upstream reworked a module:

  1. Read the old implementation - Understand what it did, what options it accepted, what it exposed.

  2. Read the new implementation - Understand the new abstractions and how they map to old behavior.

  3. Verify feature parity - For each capability in the old code, confirm the new code preserves it or explicitly removes it.

  4. Grep for stragglers - Search for old names/concepts that may have been missed in switch statements, handlers, UI components.

  5. Test the boundaries - CLI flags, SDK options, event handlers, default values—these are where regressions hide.

Quick checks

bash
# Find all uses of an old concept that may need updating
rg "oldConceptName" --type ts

# Compare default values between versions
git show upstream/main:path/to/file.ts | rg "default|DEFAULT"

# Check if all enum/union values have handlers
rg "case \"" path/to/file.ts

13) Quick audit checklist

Use this as a final pass before you finish:

  • [ ] Import extensions follow the local package convention (no blanket .js stripping)
  • [ ] No Node-only APIs in new/ported code
  • [ ] All package scopes updated
  • [ ] package.json scripts use Bun
  • [ ] Prompts are .md text imports (no inline prompt strings)
  • [ ] No console.* in coding-agent (use logger)
  • [ ] Assets load via Bun embed patterns (no copy scripts)
  • [ ] Tests or checks run (or explicitly noted as blocked)
  • [ ] No functionality regressions (see sections 11-12)

14) Commit message format

When committing a backport, follow the repo format <type>(scope): <past-tense description> and keep the commit range in the title.

fix(coding-agent): backported pi-mono changes (<from>..<to>)

packages/<package>:
- <type>: <description>
- <type>: <description> (#<issue> by @<contributor>)

packages/<other-package>:
- <type>: <description>

Example:

fix(coding-agent): backported pi-mono changes (9f3eef65f..52532c7c0)

packages/ai:
- fix: handle "sensitive" stop reason from Anthropic API
- fix: normalize tool call IDs with special characters for Responses API
- fix: add overflow detection for Bedrock, MiniMax, Kimi providers
- fix: 429 status is rate limiting, not context overflow

packages/tui:
- fix: refactored autocomplete state tracking
- fix: file autocomplete should not trigger on empty text
- fix: configurable autocomplete max visible items
- fix: improved table column width calculation with word-aware wrapping

packages/coding-agent:
- fix: preserve external config.yml edits on save (#1046 by @nicobailonMD)
- fix: resolve macOS NFD and curly quote variants in file paths

Rules:

  • Group changes by package
  • Use conventional commit types (fix, feat, refactor, perf, docs)
  • Include upstream issue/PR numbers and contributor attribution for external contributions
  • The commit range in the title helps track sync points

15) Intentional Divergences

Our fork has architectural decisions that differ from upstream. Do not port these upstream patterns:

UI Architecture

UpstreamOur ForkReason
FooterDataProvider classStatusLineComponentSimpler, integrated status line
ctx.ui.setHeader() / ctx.ui.setFooter()Stub in non-TUI modesImplemented in TUI, no-op elsewhere
ctx.ui.setEditorComponent()Stub in non-TUI modesImplemented in TUI, no-op elsewhere
InteractiveModeOptions options objectPositional constructor args (options type still exported)Keep constructor signature; update the type when upstream adds fields

Component Naming

UpstreamOur Fork
extension-input.tshook-input.ts
extension-selector.tshook-selector.ts
ExtensionInputComponentHookInputComponent
ExtensionSelectorComponentHookSelectorComponent

API Naming

UpstreamOur ForkNotes
sessionManager.appendSessionInfo(name)sessionManager.setSessionName(name)We use sessionName throughout
sessionManager.getSessionName()sessionManager.getSessionName()Same (we unified to match upstream's RPC)
agent.sessionName / setSessionName()agent.sessionName / setSessionName()Same

File Consolidation

UpstreamOur ForkReason
clipboard.ts + clipboard-image.ts (tool files)@oh-my-pi/pi-natives clipboard moduleMerged into N-API native implementation

Test Framework

UpstreamOur Fork
vitest with vi.mock()bun:test with vi from bun
node:test assertionsexpect() matchers

Tool Architecture

UpstreamOur ForkNotes
createTool(cwd: string, options?)createTools(session: ToolSession) via BUILTIN_TOOLS registryTool factories accept ToolSession and can return null
Per-tool *Operations interfacesPer-tool interfaces remain (FindOperations, GrepOperations)Used for SSH/remote overrides
Node.js fs/promises everywhereBun.file()/Bun.write() for files; node:fs/promises for dirsPrefer Bun APIs when they simplify

Auth Storage

UpstreamOur ForkNotes
proper-lockfile + auth.jsonagent.db (bun:sqlite)Credentials stored exclusively in agent.db
Single credential per providerMulti-credential with round-robin selectionSession affinity and backoff logic preserved

Extensions

UpstreamOur Fork
jiti for TypeScript loadingNative Bun import()
pkg.pi manifest fieldpkg.omp ?? pkg.pi (prefer our namespace)

Skip These Upstream Features

When porting, skip these files/features entirely:

  • footer-data-provider.ts — we use StatusLineComponent
  • clipboard-image.ts — clipboard is in @oh-my-pi/pi-natives N-API module
  • GitHub workflow files — we have our own CI
  • models.generated.ts — auto-generated, regenerate locally (as models.json instead)

Features We Added (Preserve These)

These exist in our fork but not upstream. Never overwrite:

  • StatusLineComponent in interactive mode
  • Multi-credential auth with session affinity
  • Capability-based discovery system (defineCapability, registerProvider, loadCapability, skillCapability, etc.)
  • MCP/Exa/SSH integrations
  • LSP writethrough for format-on-save
  • Bash interception (checkBashInterception)
  • Fuzzy path suggestions in read tool